Hermes Team
a9c04b75a2
Launching the app died with "'dict' object has no attribute 'readiness'".
TeamView.__init__ forwarded its legacy app_state dict into update_data(snapshot),
whose guard only handled None, so {} reached snapshot.readiness. TeamView is the
default view, so the window never appeared.
Fixes the call site and hardens every snapshot guard to fall back on anything
that is not a HubSnapshot. Adds tests/test_view_startup_contract.py, which
checks both conditions statically and therefore runs headless; verified to fail
on the pre-fix sources.
The GUI-import invariant previously matched the literal string "customtkinter",
which missed modules pulling it transitively. Rewritten over the AST, it
immediately found test_codex_opencode_wizard.py importing router.ui.components
without pytest.importorskip — the same defect that took the release gate down
once before, hidden until now behind conftest's name-based skip.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
119 lines
4.2 KiB
Python
119 lines
4.2 KiB
Python
"""Import invariants for the whole package.
|
|
|
|
Guards against two classes of rot that unit tests do not catch:
|
|
|
|
1. Dead-on-arrival modules — code that references project-internal names which
|
|
do not exist, so the module has never been imported by anything.
|
|
(Found in review: ``deepseek_adapter`` imported ``ProviderAdapter`` and
|
|
``ProfileConfig``, neither of which exists anywhere in ``src/``.)
|
|
|
|
2. Missing ``pytest.importorskip`` guards — a test module that imports an
|
|
optional UI dependency at module scope aborts collection of the ENTIRE
|
|
session instead of skipping itself.
|
|
|
|
Missing *third-party* optional dependencies (customtkinter, PIL, ...) are
|
|
skipped, not failed: those are legitimately absent in headless environments.
|
|
Broken *internal* references always fail.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import ast
|
|
import importlib
|
|
import pkgutil
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
TESTS_DIR = Path(__file__).resolve().parent
|
|
# ``antigravity_provider`` is a PEP 420 namespace package whose ``__path__`` also
|
|
# contains the *installed* plugin copy under %LOCALAPPDATA%. Walk only the
|
|
# repository sources, so the suite never grades a different deployed version.
|
|
PACKAGE_ROOT = TESTS_DIR.parent / "src" / "antigravity_provider"
|
|
|
|
# Third-party packages that may legitimately be absent (GUI / optional extras).
|
|
OPTIONAL_EXTERNAL_MODULES = {
|
|
"customtkinter",
|
|
"tkinter",
|
|
"PIL",
|
|
"psutil",
|
|
"fastapi",
|
|
"uvicorn",
|
|
"pydantic",
|
|
}
|
|
|
|
|
|
def _iter_module_names() -> list[str]:
|
|
names: list[str] = []
|
|
for mod in pkgutil.walk_packages([str(PACKAGE_ROOT)], prefix="antigravity_provider."):
|
|
names.append(mod.name)
|
|
return sorted(names)
|
|
|
|
|
|
def _missing_external(exc: ImportError) -> str | None:
|
|
"""Return the optional third-party module name if *exc* is caused by one."""
|
|
name = getattr(exc, "name", None) or ""
|
|
root = name.split(".")[0]
|
|
if root in OPTIONAL_EXTERNAL_MODULES:
|
|
return root
|
|
return None
|
|
|
|
|
|
@pytest.mark.unit
|
|
@pytest.mark.parametrize("module_name", _iter_module_names())
|
|
def test_module_is_importable(module_name: str) -> None:
|
|
"""Every shipped module must import, or fail only on an absent optional extra."""
|
|
try:
|
|
importlib.import_module(module_name)
|
|
except ImportError as exc:
|
|
external = _missing_external(exc)
|
|
if external:
|
|
pytest.skip(f"optional dependency '{external}' not installed")
|
|
pytest.fail(
|
|
f"{module_name} is not importable — broken internal reference: {exc}\n"
|
|
"The module ships in the package but has never been executed by anything."
|
|
)
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_gui_test_modules_guard_optional_ui_dependency() -> None:
|
|
"""Test modules touching customtkinter must call pytest.importorskip.
|
|
|
|
Without the guard a headless environment aborts collection of the whole
|
|
session ("Interrupted: 1 error during collection") instead of skipping the
|
|
affected module, which takes the release gate down with it.
|
|
"""
|
|
# Modules that pull the GUI toolkit in transitively when imported.
|
|
GUI_BEARING_PREFIXES = (
|
|
"customtkinter",
|
|
"antigravity_provider.router.ui",
|
|
"antigravity_provider.router.hermes_hub_app",
|
|
)
|
|
|
|
def _imports_gui(tree: ast.AST) -> bool:
|
|
for node in ast.walk(tree):
|
|
if isinstance(node, ast.Import):
|
|
if any(a.name.startswith(GUI_BEARING_PREFIXES) for a in node.names):
|
|
return True
|
|
elif isinstance(node, ast.ImportFrom):
|
|
if (node.module or "").startswith(GUI_BEARING_PREFIXES):
|
|
return True
|
|
return False
|
|
|
|
offenders: list[str] = []
|
|
for path in sorted(TESTS_DIR.glob("test_*.py")):
|
|
text = path.read_text(encoding="utf-8", errors="ignore")
|
|
try:
|
|
tree = ast.parse(text)
|
|
except SyntaxError:
|
|
continue
|
|
# A mention in prose is not an import; only real imports need the guard.
|
|
if not _imports_gui(tree):
|
|
continue
|
|
if "importorskip" not in text:
|
|
offenders.append(path.name)
|
|
|
|
assert not offenders, (
|
|
"test modules import customtkinter without pytest.importorskip: "
|
|
+ ", ".join(offenders)
|
|
+ " — add pytest.importorskip('customtkinter') above the import"
|
|
)
|