Handle socket-activated SSH runtime and require UFW boot readiness #20
5 changed files with 96 additions and 2 deletions
6
.github/workflows/bash-syntax.yml
vendored
6
.github/workflows/bash-syntax.yml
vendored
|
|
@ -59,3 +59,9 @@ jobs:
|
||||||
|
|
||||||
- name: Test initial backup policy and upload retry
|
- name: Test initial backup policy and upload retry
|
||||||
run: bash tests/test-backup-initial-retry.sh
|
run: bash tests/test-backup-initial-retry.sh
|
||||||
|
|
||||||
|
- name: Test step 3 socket activation runtime directory
|
||||||
|
run: bash tests/test-step3-runtime-directory.sh
|
||||||
|
|
||||||
|
- name: Test step 2 UFW boot readiness
|
||||||
|
run: bash tests/test-step2-ufw-boot.sh
|
||||||
|
|
|
||||||
|
|
@ -17,6 +17,20 @@ require_command() {
|
||||||
command -v "$1" >/dev/null 2>&1 || die "Не найдена команда: $1"
|
command -v "$1" >/dev/null 2>&1 || die "Не найдена команда: $1"
|
||||||
}
|
}
|
||||||
|
|
||||||
|
ensure_ufw_boot_service() {
|
||||||
|
local state
|
||||||
|
state="$(systemctl is-enabled ufw.service 2>/dev/null || true)"
|
||||||
|
case "$state" in
|
||||||
|
masked|masked-runtime)
|
||||||
|
die "ufw.service замаскирована: сначала проверьте причину маски и включите службу вручную. Правила не изменены."
|
||||||
|
;;
|
||||||
|
esac
|
||||||
|
systemctl enable ufw.service \
|
||||||
|
|| die "Не удалось включить автозапуск ufw.service; правила не изменены"
|
||||||
|
systemctl is-enabled --quiet ufw.service \
|
||||||
|
|| die "Автозапуск ufw.service не подтверждён; правила не изменены"
|
||||||
|
}
|
||||||
|
|
||||||
is_valid_port() {
|
is_valid_port() {
|
||||||
local port="$1"
|
local port="$1"
|
||||||
[[ "$port" =~ ^[0-9]{1,5}$ ]] || return 1
|
[[ "$port" =~ ^[0-9]{1,5}$ ]] || return 1
|
||||||
|
|
@ -403,9 +417,10 @@ if [[ "$ACTION" == install ]]; then
|
||||||
apt-get install -y \
|
apt-get install -y \
|
||||||
sudo ufw fail2ban curl ca-certificates openssl openssh-server logrotate iproute2
|
sudo ufw fail2ban curl ca-certificates openssl openssh-server logrotate iproute2
|
||||||
|
|
||||||
for command_name in ip sed sysctl ufw; do
|
for command_name in ip sed sysctl ufw systemctl; do
|
||||||
require_command "$command_name"
|
require_command "$command_name"
|
||||||
done
|
done
|
||||||
|
ensure_ufw_boot_service
|
||||||
install -d -m 700 -o root -g root "$CONFIG_DIR"
|
install -d -m 700 -o root -g root "$CONFIG_DIR"
|
||||||
load_managed_rules
|
load_managed_rules
|
||||||
PREVIOUS_MANAGED_RULES=("${MANAGED_RULES[@]}")
|
PREVIOUS_MANAGED_RULES=("${MANAGED_RULES[@]}")
|
||||||
|
|
@ -415,9 +430,10 @@ if [[ "$ACTION" == install ]]; then
|
||||||
save_configuration
|
save_configuration
|
||||||
log "SSH-порт ${SSH_PORT} сохранён для этапа 3"
|
log "SSH-порт ${SSH_PORT} сохранён для этапа 3"
|
||||||
else
|
else
|
||||||
for command_name in ip sed sysctl ufw; do
|
for command_name in ip sed sysctl ufw systemctl; do
|
||||||
require_command "$command_name"
|
require_command "$command_name"
|
||||||
done
|
done
|
||||||
|
ensure_ufw_boot_service
|
||||||
install -d -m 700 -o root -g root "$CONFIG_DIR"
|
install -d -m 700 -o root -g root "$CONFIG_DIR"
|
||||||
SSH_PORT="$(read_saved_value "$SSH_PORT_CONFIG" SSH_PORT)"
|
SSH_PORT="$(read_saved_value "$SSH_PORT_CONFIG" SSH_PORT)"
|
||||||
is_valid_port "$SSH_PORT" || SSH_PORT="$DEFAULT_SSH_PORT"
|
is_valid_port "$SSH_PORT" || SSH_PORT="$DEFAULT_SSH_PORT"
|
||||||
|
|
|
||||||
|
|
@ -73,6 +73,12 @@ is_valid_port() {
|
||||||
(( 10#$port >= 1 && 10#$port <= 65535 ))
|
(( 10#$port >= 1 && 10#$port <= 65535 ))
|
||||||
}
|
}
|
||||||
|
|
||||||
|
prepare_sshd_runtime_directory() {
|
||||||
|
# Socket-activated Ubuntu can have no active ssh.service after an upgrade.
|
||||||
|
# Its RuntimeDirectory then does not exist, but standalone sshd -t needs it.
|
||||||
|
install -d -o root -g root -m 755 /run/sshd
|
||||||
|
}
|
||||||
|
|
||||||
read_ip_mode() {
|
read_ip_mode() {
|
||||||
local mode=both
|
local mode=both
|
||||||
if [[ -e "$IP_FAMILY_CONFIG" ]]; then
|
if [[ -e "$IP_FAMILY_CONFIG" ]]; then
|
||||||
|
|
@ -517,6 +523,7 @@ UsePAM yes
|
||||||
EOF
|
EOF
|
||||||
chmod 644 "$SSHD_DROPIN"
|
chmod 644 "$SSHD_DROPIN"
|
||||||
|
|
||||||
|
prepare_sshd_runtime_directory
|
||||||
sshd -t || die "sshd syntax validation failed"
|
sshd -t || die "sshd syntax validation failed"
|
||||||
# Capture the complete output once. With pipefail enabled, piping `sshd -T`
|
# Capture the complete output once. With pipefail enabled, piping `sshd -T`
|
||||||
# into an awk program that exits after the first match can terminate sshd with
|
# into an awk program that exits after the first match can terminate sshd with
|
||||||
|
|
|
||||||
41
tests/test-step2-ufw-boot.sh
Normal file
41
tests/test-step2-ufw-boot.sh
Normal file
|
|
@ -0,0 +1,41 @@
|
||||||
|
#!/usr/bin/env bash
|
||||||
|
set -Eeuo pipefail
|
||||||
|
cd -- "$(dirname -- "${BASH_SOURCE[0]}")/.."
|
||||||
|
source <(awk '/^\[\[ "\$EUID"/{exit} {print}' ochenstarik-server-2.sh)
|
||||||
|
test_dir="$(mktemp -d)"
|
||||||
|
trap 'rm -rf -- "$test_dir"' EXIT
|
||||||
|
|
||||||
|
systemctl() {
|
||||||
|
printf '%s\n' "$*" >> "$test_dir/calls"
|
||||||
|
case "$*" in
|
||||||
|
'is-enabled ufw.service') cat "$test_dir/state"; return 1 ;;
|
||||||
|
'enable ufw.service')
|
||||||
|
[[ "$scenario" != enable-failed ]] || return 1
|
||||||
|
[[ "$scenario" == verify-failed ]] || printf enabled > "$test_dir/state"
|
||||||
|
;;
|
||||||
|
'is-enabled --quiet ufw.service') [[ "$(cat "$test_dir/state")" == enabled ]] ;;
|
||||||
|
*) return 99 ;;
|
||||||
|
esac
|
||||||
|
}
|
||||||
|
|
||||||
|
for state in masked masked-runtime; do
|
||||||
|
printf '%s' "$state" > "$test_dir/state"
|
||||||
|
: > "$test_dir/calls"
|
||||||
|
scenario=masked
|
||||||
|
if (ensure_ufw_boot_service) > "$test_dir/output" 2>&1; then exit 1; fi
|
||||||
|
! grep -q '^enable ' "$test_dir/calls"
|
||||||
|
[[ "$(cat "$test_dir/state")" == "$state" ]]
|
||||||
|
done
|
||||||
|
|
||||||
|
for scenario in disabled enabled enable-failed verify-failed; do
|
||||||
|
printf '%s' "$scenario" > "$test_dir/state"
|
||||||
|
: > "$test_dir/calls"
|
||||||
|
if [[ "$scenario" == *-failed ]]; then
|
||||||
|
if (ensure_ufw_boot_service) > "$test_dir/output" 2>&1; then exit 1; fi
|
||||||
|
else
|
||||||
|
ensure_ufw_boot_service
|
||||||
|
[[ "$(cat "$test_dir/state")" == enabled ]]
|
||||||
|
grep -qx 'is-enabled --quiet ufw.service' "$test_dir/calls"
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
printf 'Step 2 UFW boot readiness tests passed.\n'
|
||||||
24
tests/test-step3-runtime-directory.sh
Normal file
24
tests/test-step3-runtime-directory.sh
Normal file
|
|
@ -0,0 +1,24 @@
|
||||||
|
#!/usr/bin/env bash
|
||||||
|
set -Eeuo pipefail
|
||||||
|
cd -- "$(dirname -- "${BASH_SOURCE[0]}")/.."
|
||||||
|
source <(awk '/^\[\[ "\$EUID"/{exit} {print}' ochenstarik-server-user-3.sh)
|
||||||
|
test_dir="$(mktemp -d)"
|
||||||
|
trap 'rm -rf -- "$test_dir"' EXIT
|
||||||
|
|
||||||
|
# Relocate just the privileged filesystem boundary; use the real install
|
||||||
|
# binary to check first creation, idempotency and repair of unsafe modes.
|
||||||
|
install() {
|
||||||
|
[[ "$*" == '-d -o root -g root -m 755 /run/sshd' ]]
|
||||||
|
/usr/bin/install -d -m 755 "$test_dir/sshd"
|
||||||
|
}
|
||||||
|
prepare_sshd_runtime_directory
|
||||||
|
[[ -d "$test_dir/sshd" && "$(stat -c %a "$test_dir/sshd")" == 755 ]]
|
||||||
|
chmod 777 "$test_dir/sshd"
|
||||||
|
prepare_sshd_runtime_directory
|
||||||
|
[[ "$(stat -c %a "$test_dir/sshd")" == 755 ]]
|
||||||
|
|
||||||
|
# The runtime prerequisite must run before standalone configuration validation.
|
||||||
|
prepare_line="$(grep -n '^prepare_sshd_runtime_directory$' ochenstarik-server-user-3.sh | cut -d: -f1)"
|
||||||
|
validate_line="$(grep -n '^sshd -t ' ochenstarik-server-user-3.sh | cut -d: -f1)"
|
||||||
|
((prepare_line < validate_line))
|
||||||
|
printf 'Step 3 socket-activation runtime directory tests passed.\n'
|
||||||
Loading…
Reference in a new issue