ochenstarik/server-monitor-manager
1
0
Fork 0
Code Issues Pull requests 6 Projects Releases 17 Packages Wiki Activity Actions

feat(control): reconcile link policies #11

Merged
ochenstarik-ui merged 2 commits from hermes/task2-b-link-reconciliation into main 2026-08-03 03:52:19 +00:00
Conversation 0 Commits 2 Files changed 14 +554 -111
ochenstarik-ui commented 2026-08-03 03:41:17 +00:00 (Migrated from github.com)
Copy link

Summary

  • add fail-closed factual nftables Link policy probing
  • reconcile desired Link state after reconnect and privileged mutations
  • serialize reconnect, disable, TTL, and certificate reenrollment paths
  • expose desired/actual drift, errors, and versions in Desktop
  • strengthen three-server acceptance contracts for factual state, disable, TTL, and restart

Security review

  • initial independent review found two HIGH concurrency/replay findings
  • both repaired with node/per-Link serialization and resumable convergence
  • independent repair-review: APPROVE; no BLOCKING/HIGH/MEDIUM findings

Verification

  • Control tests: 69/69 PASS
  • Desktop security tests: 12/12 PASS
  • Desktop Release x64: 0 warnings, 0 errors
  • changed shell syntax: PASS
  • bootstrap contract: PASS
  • Windows Desktop contracts: PASS before backend-only repair
  • git diff --check: PASS

Physical acceptance

Not run: HUB/SOURCE SSH hosts/users, WireGuard IPs, and identity file are not configured in this environment. Contract/mock evidence is not presented as physical acceptance.

## Summary - add fail-closed factual nftables Link policy probing - reconcile desired Link state after reconnect and privileged mutations - serialize reconnect, disable, TTL, and certificate reenrollment paths - expose desired/actual drift, errors, and versions in Desktop - strengthen three-server acceptance contracts for factual state, disable, TTL, and restart ## Security review - initial independent review found two HIGH concurrency/replay findings - both repaired with node/per-Link serialization and resumable convergence - independent repair-review: APPROVE; no BLOCKING/HIGH/MEDIUM findings ## Verification - Control tests: 69/69 PASS - Desktop security tests: 12/12 PASS - Desktop Release x64: 0 warnings, 0 errors - changed shell syntax: PASS - bootstrap contract: PASS - Windows Desktop contracts: PASS before backend-only repair - git diff --check: PASS ## Physical acceptance Not run: HUB/SOURCE SSH hosts/users, WireGuard IPs, and identity file are not configured in this environment. Contract/mock evidence is not presented as physical acceptance.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: ochenstarik/server-monitor-manager#11
No description provided.
Delete branch "hermes/task2-b-link-reconciliation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?